[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Drop useless virFileWrapperFdCatchError



On Thu, Feb 07, 2013 at 12:36:37PM +0100, Michal Privoznik wrote:
> We are requesting for stderr catching for all cases in
> virFileWrapperFdNew(). There is no need to have a separate
> function just to report an error, esp. when we can do it in
> virFileWrapperFdClose().
> ---
>  src/libvirt_private.syms |  1 -
>  src/qemu/qemu_driver.c   |  5 +----
>  src/util/virfile.c       | 21 ++++++---------------
>  src/util/virfile.h       |  2 --
>  4 files changed, 7 insertions(+), 22 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]