[libvirt] [PATCH 08/13] qemumonitortestutils: Resolve resource leaks found by Valgrind
Daniel P. Berrange
berrange at redhat.com
Thu Feb 7 15:54:44 UTC 2013
On Wed, Feb 06, 2013 at 04:35:42PM -0500, John Ferlan wrote:
> When Valgrind runs the 'qemumonitorjsontest' it would claim that the
> thread created is leaked. That's because the virThreadJoin won't get
> called due to the 'running' flag being cleared. In order to avoid that,
> call virThreadJoin unconditionally at cleanup time. Also noted that the
> qemuMonitorTestWorker() didn't get the test mutex lock on the failure path.
>
> The incoming and outgoing buffers allocated by qemuMonitorTestIO() and
> qemuMonitorTestAddReponse() were never VIR_FREE()'d in qemuMonitorTestFree().
> ---
> tests/qemumonitortestutils.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
AKC
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list