[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/13] qemumonitorjsontest: Resolve resource leaks found by Valgrind



On Wed, Feb 06, 2013 at 04:35:41PM -0500, John Ferlan wrote:
> The 'package' string returned by qemuMonitorGetVersion() needs to
> be VIR_FREE()'d.
> 
> testQemuMonitorJSONGetMachines(), testQemuMonitorJSONGetCPUDefinitions(),
> and testQemuMonitorJSONGetCommands() did not VIR_FREE() the array and
> array elements allocated by their respective qemuMonitorGet* routines.
> ---
>  tests/qemumonitorjsontest.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]