[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/15] util: eliminate generic hook from virExecWithHook

On 02/07/2013 02:37 PM, Laine Stump wrote:
> virExecWithHook is only called from one place, so it always has the
> same "hook" function (virHookCommand), and the data sent to that
> function is always a virCommandPtr, so eliminate the function and
> generic data from the arglist, and replace it with "virCommandPtr
> cmd". The call to (hook)(data) is replaced with
> "virHookCommand(cmd)". Finally, virExecWithHook is renamed to virExec.
> Indentation has been updated only for code that will remain after the
> next patch, which will remove all other args to virExec (since they
> are now redundant, as they're all members of virCommandPtr).
> ---
>  src/util/vircommand.c | 79 ++++++++++++++++++++++++---------------------------
>  1 file changed, 37 insertions(+), 42 deletions(-)


Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]