[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/15] util: eliminate extra args from virExec



On 02/07/2013 02:37 PM, Laine Stump wrote:
> All args except "cmd" in the call to virExec are now redundant, since
> they can all be found in cmd, so remove the args and reference the
> data directly in cmd. One exception to this is that "infd" was being
> modified within virExec, and modifying the original in cmd caused make
> check failures, so cmd->infd is copied to a local, and the local is
> used during virExec().
> ---
>  src/util/vircommand.c | 142 +++++++++++++++++---------------------------------
>  1 file changed, 49 insertions(+), 93 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]