[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/4] net: support set public ip for forward mode nat



On Mon, Feb 04, 2013 at 10:45:24AM +0100, Natanael Copa wrote:
> Support setting which public ip to use for NAT via attribute
> address in subelement <nat> in <forward>:
> 
> ...
>   <forward mode='nat'>
>       <nat address='1.2.3.4'/>
>   </forward>

Unless I'm mis-understanding, this is just identical to
using a range, with the start + end addresses equal eg

  <forward mode='nat'>
    <nat>
      <address start='1.2.3.4' end='1.2.3.4'/>
    </nat>
  </forward>

if so, then this is redundant - we should just use the
<address start='1.2.3.4' end='1.2.3.4'/> syntax
for everything, and not special case the scenario
where start+end are equal.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]