[libvirt] [PATCH v2 1/4] util: refactor iptables command construction into multiple steps
Daniel P. Berrange
berrange at redhat.com
Fri Feb 8 17:25:31 UTC 2013
On Mon, Feb 04, 2013 at 10:45:23AM +0100, Natanael Copa wrote:
> Instead of creating an iptables command in one shot, do it in steps
> so we can add conditional options like physdev and protocol.
>
> This removes code duplication while keeping existing behaviour.
>
> Signed-off-by: Natanael Copa <ncopa at alpinelinux.org>
> ---
> This patch is unmodified since last time i sent it [1].
>
> [1] https://www.redhat.com/archives/libvir-list/2012-November/msg00986.html
>
> src/util/viriptables.c | 130 ++++++++++++++++++++++---------------------------
> 1 file changed, 58 insertions(+), 72 deletions(-)
ACK, looks fine.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list