[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 1/2] virDomainSaveXML: Reject domains which name contain '/'



On 02/08/2013 11:44 AM, Jim Fehlig wrote:

>> Seems this should be in a more "general" location. Would the same rules apply to
>> other objects (networks, storage, etc.)?  What other characters should be avoided? 
>> Having a comma, semi-colon, colon, etc. could have interesting results.
> 
> Yeah, comma is an interesting one for qemu since that delimits option
> subarguments.  E.g. trying to start a qemu instance with name 'foo,bar'
> results in
> 
> $ virsh start "foo,bar"
> error: Failed to start domain foo,bar
> error: internal error process exited while connecting to monitor:
> Unknown subargument bar to -name

That's an independent bug - we already have a function for properly
quoting commas when passing to qemu; if we would use that function
properly, the command line would be -name foo,,bar, at which point qemu
would be using 'foo,bar' internally anywhere the name is needed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]