[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/11] Revisit xen driver Coverity cleanup changes



On 02/08/2013 04:15 PM, Jim Fehlig wrote:
>> I was trying to go with the 80 column rule.  For 99% they could fit on
>> one line if I removed one extra space. For a couple, spanning 2 lines
>> kept the 80 columns in effect. In looking at other drivers - I don't
>> think any of them typecast the *PrivatePtr)<var>->privateData, so I
>> could remove that too. I left them in only because they were there.
>>   
> 
> Yeah, good point. And dropping the cast will make all of them fit within
> 80 columns :).

The cast is needed in C++; but libvirt is C, and void* automatically
casts to whatever type you need without having to be explicit.  Go ahead
and drop the cast.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]