[libvirt] [PATCH] Check if classes are derived from object
Daniel P. Berrange
berrange at redhat.com
Mon Feb 11 16:24:15 UTC 2013
On Mon, Feb 11, 2013 at 05:20:31PM +0100, Guido Günther wrote:
> This makes sure we don't regress to old style classes
> ---
> Just a minor addition that came up while verifying if the corresponding
> Debian bug is fixed.
>
> python/sanitytest.py | 27 ++++++++++++++++-----------
> 1 file changed, 16 insertions(+), 11 deletions(-)
>
> diff --git a/python/sanitytest.py b/python/sanitytest.py
> index 047450b..ace6792 100644
> --- a/python/sanitytest.py
> +++ b/python/sanitytest.py
> @@ -7,17 +7,22 @@ globals = dir(libvirt)
> # Sanity test that the generator hasn't gone wrong
>
> # Look for core classes
> -assert("virConnect" in globals)
> -assert("virDomain" in globals)
> -assert("virDomainSnapshot" in globals)
> -assert("virInterface" in globals)
> -assert("virNWFilter" in globals)
> -assert("virNodeDevice" in globals)
> -assert("virNetwork" in globals)
> -assert("virSecret" in globals)
> -assert("virStoragePool" in globals)
> -assert("virStorageVol" in globals)
> -assert("virStream" in globals)
> +for clsname in ["virConnect",
> + "virDomain",
> + "virDomainSnapshot",
> + "virInterface",
> + "virNWFilter",
> + "virNodeDevice",
> + "virNetwork",
> + "virSecret",
> + "virStoragePool",
> + "virStorageVol",
> + "virStream",
> + ]:
> + assert(clsname in globals)
> + assert(object in getattr(libvirt, clsname).__bases__)
> +
> +# Constants
> assert("VIR_CONNECT_RO" in globals)
ACK, good idea.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list