[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Clean some comments about locking



On Tue, Feb 12, 2013 at 08:14:40AM -0700, Eric Blake wrote:
> On 02/12/2013 05:52 AM, Martin Kletzander wrote:
> > Since the BQDL has been broken, this patch tries to cleanup some
> > information about it in various comments.
> > ---
> > To be applied after Dan's patch [1] which removes unnecessary
> > qemuDriverLocks.
> > 
> > @@ -1734,7 +1733,7 @@ qemuDomainSnapshotDiscardAllMetadata(virQEMUDriverPtr driver,
> >  }
> > 
> >  /*
> > - * The caller must hold a lock on both driver and vm, and there must
> > + * The caller must hold a lock the vm and there must
> 
> s/lock the/lock on the/
> 
> ACK, whether Dan squashes this in directly or you push as a followup.

It really ought to be squashed into the main patch I think

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]