[libvirt] [PATCHv2 ACKED 01/15] util: eliminate generic hook from virExecWithHook

Daniel P. Berrange berrange at redhat.com
Wed Feb 13 10:20:50 UTC 2013


On Tue, Feb 12, 2013 at 03:15:35PM -0500, Laine Stump wrote:
> virExecWithHook is only called from one place, so it always has the
> same "hook" function (virHookCommand), and the data sent to that
> function is always a virCommandPtr, so eliminate the function and
> generic data from the arglist, and replace it with "virCommandPtr
> cmd". The call to (hook)(data) is replaced with
> "virHookCommand(cmd)". Finally, virExecWithHook is renamed to virExec.
> 
> Indentation has been updated only for code that will remain after the
> next patch, which will remove all other args to virExec (since they
> are now redundant, as they're all members of virCommandPtr).
> ---
> Change from V1: rebased.
> 
>  src/util/vircommand.c | 79 ++++++++++++++++++++++++---------------------------
>  1 file changed, 37 insertions(+), 42 deletions(-)

If you have a series like this where a number of patches have been
ACKd on previous posting, just merge the ACKd patches. Don't keep
re-posting them, unless they depend on earlier patches in the series
which are not yet ACKd.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list