[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/5] Clean up after recent Coverity scan

This is the last round of cleanup with a few Coverity errors from the
tests trees and a couple that just showed up in my recent scans within
security and virsh. The commandtest still has Valgrind errors, but errors
are not new to this change.

After this round of Coverity changes, the only remaining Coverity warnings
reported are within the gnulib tree. A few have been there all along within
vasnprintf.c, while others are new with the recent gnulib update (regexec.c,
regex_internal.c, and regcomp.c).

Once these are submitted I will have a baseline from which I can make
periodic comparisons. Since Coverity will sometimes "find" issues unrelated
to recent changes, using git bisect to point the fickle finger of fate at
a recent submission may not be possible.

John Ferlan (5):
  drivermodule: Ignore coverity warning about leaked_storage
  commandtest: Resolve some coverity resource leaks
  vircommand: Remove unnecessary sa_assert
  virsh: Resolve possible NULL dereference
  security: Remove unnecessary checks for mgr == NULL

 src/security/security_dac.c     |  6 ------
 src/security/security_selinux.c |  6 ------
 src/util/vircommand.c           |  3 ---
 tests/commandtest.c             | 17 ++++++++++++-----
 tests/virdrivermoduletest.c     |  2 ++
 tools/virsh.c                   |  4 ++--
 6 files changed, 16 insertions(+), 22 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]