[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add capabilities bit for -no-kvm-pit-reinjection

On Mon, Feb 18, 2013 at 7:22 AM, Laine Stump <laine laine org> wrote:
> On 02/18/2013 01:10 AM, Doug Goldstein wrote:
>> The conversion to qemuCaps dropped the ability with qemu{,-kvm} 1.2 and
>> newer to set the lost tick policy for the PIT. While the
>> -no-kvm-pit-reinjection option is depreacated, it is still supported at
>> least through 1.4, it is better to not lose the functionality.
> After 1.4 will adding it to a commandline result in an error, or will it
> be ignored?

It still exists in qemu/master.

> Also, will something else be replacing it, or is it just no longer
> useful/necessary?

Yes. Patches coming to utilize -device
kvm-pit,lost-tick-policy=${valuehere} shortly. Which appeared at least
as early as 1.1

> It would be a bit perturbing if an "implied" capability disappeared,
> with no way to detect via QMP whether or not it was there.

The newer command line argument cannot be detected afaik right now
either. But its one of those things that always exists. I plan on
digging into it and more patches to come. But this patch came from the
fact that the functionality (which unfortunately a guest needs)
disappeared when I switched from qemu 1.1 to 1.2. Basically this was
an "oh crap get the feature back" patch.

>> ---
>>  src/qemu/qemu_capabilities.c | 1 +
>>  1 file changed, 1 insertion(+)
>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>> index 51fc9dc..af52bbf 100644
>> --- a/src/qemu/qemu_capabilities.c
>> +++ b/src/qemu/qemu_capabilities.c
>> @@ -2284,6 +2284,7 @@ virQEMUCapsInitQMPBasic(virQEMUCapsPtr qemuCaps)
>>      virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_USER_CONFIG);
>>      virQEMUCapsSet(qemuCaps, QEMU_CAPS_NETDEV_BRIDGE);
>>      virQEMUCapsSet(qemuCaps, QEMU_CAPS_SECCOMP_SANDBOX);
>> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_KVM_PIT);
>>  }
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

Doug Goldstein

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]