[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 00/12] Rework storage migration



On 02/06/2013 08:52 AM, Michal Privoznik wrote:

> Michal Privoznik (12):
>   qemu: Introduce NBD_SERVER capability
>   Introduce NBD migration cookie
>   qemu: Introduce nbd-server-start command
>   qemu: Introduce nbd-server-add command
>   qemu: Introduce nbd-server-stop command
>   qemu_migration: Introduce qemuMigrationStartNBDServer()
>   qemu_migration: Introduce qemuMigrationDriveMirror
>   qemu_domain: Introduce qemuDomainGetDiskBlockInfo
>   qemu_migration: Check size prerequisites
>   qemu_migration: Stop NBD server at Finish phase
>   qemu_migration: Cancel running jobs on failed migration
>   qemu_migration: Unlink pre-created storage on error
> 
>  src/qemu/qemu_capabilities.c |   4 +-
>  src/qemu/qemu_capabilities.h |   1 +
>  src/qemu/qemu_domain.c       | 157 ++++++++-
>  src/qemu/qemu_domain.h       |   7 +
>  src/qemu/qemu_driver.c       | 124 +------
>  src/qemu/qemu_migration.c    | 769 ++++++++++++++++++++++++++++++++++++++++++-
>  src/qemu/qemu_monitor.c      |  63 ++++
>  src/qemu/qemu_monitor.h      |   7 +
>  src/qemu/qemu_monitor_json.c | 102 ++++++
>  src/qemu/qemu_monitor_json.h |   7 +
>  src/qemu/qemu_process.c      |  13 +
>  11 files changed, 1118 insertions(+), 136 deletions(-)
> 

Seeing as this has been sitting around awhile I looked through the
changes and made comments on changes 6, 7, 8, 9, and 12.

The others I didn't have comments on.  Consider me a soft ACK -
hopefully one of the original v1/v2 reviewers can also chime in!

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]