[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rpc: Avoid deadlock when closing client connection



On Tue, Feb 19, 2013 at 14:21:42 +0000, Daniel P. Berrange wrote:
> On Mon, Feb 18, 2013 at 03:52:40PM +0100, Jiri Denemark wrote:
> > We need to drop the server lock before calling virObjectUnlock(client)
> > since in case we had the last reference to the client, its dispose
> > callback would be called and that could possibly try to lock the server
> > and cause a deadlock. This is exactly what happens when there is only
> > one QEMU domain running and it is marked to be autodestroyed when the
> > connection dies. This results in qemuProcessAutoDestroy ->
> > qemuProcessStop -> virNetServerRemoveShutdownInhibition call sequence,
> > where the last function locks the server.
> > ---
> 
> ACK

Thanks, pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]