[libvirt] [PATCH] maint: enforce private symbol section sorting
Eric Blake
eblake at redhat.com
Wed Feb 20 16:28:04 UTC 2013
On 02/20/2013 06:41 AM, Daniel P. Berrange wrote:
> On Wed, Feb 20, 2013 at 06:34:33AM -0700, Eric Blake wrote:
>> Automating a sorting check is the only way to ensure we don't
>> regress. Suggested by Dan Berrange.
>>
>>
>> - if (/^\s*$/) {
>> + if (/^#/) {
>
> This can match plain comments, or comments with a filename
>
>> + $_ =~ s/^# //;
>> + $groupfile = $_;
>
> So I'd split this into two:
>
> if (/^#\s*((\w+\/)*(\w+\.h$))\s*$) {?
> $groupfile = $1;
> } elif (/^#\s*$/) {
> # Ignore comments
> ...
Good idea.
>
>> + } elsif (/^\s*$/) {
>
> ACK either with or without the change
Pushed with the split check.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130220/a5283e26/attachment-0001.sig>
More information about the libvir-list
mailing list