[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/16] conf: Refactor ABI stability checking and break long lines



On 02/20/2013 12:06 PM, Peter Krempa wrote:
> Get rid of the "identical" variable in the ABI stability checks in favor
> of return statements and break or refactor very long lines where
> possible.
> ---
>  src/conf/domain_conf.c | 469 +++++++++++++++++++++----------------------------
>  1 file changed, 200 insertions(+), 269 deletions(-)

ACK (although in general I have some misgivings about cosmetic changes
like this, as they obscure the history of the modified lines, making it
more tedious to sift through the past commit logs to understand why
certain bits of code exist / what changed, etc).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]