[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/9] qemu: Introduce NBD_SERVER capability



On Thu, Feb 21, 2013 at 14:39:18 +0100, Michal Privoznik wrote:
> This just keeps track whether qemu knows nbd-server-* commands
> so we can use it during migration or not.
> ---
>  src/qemu/qemu_capabilities.c | 4 +++-
>  src/qemu/qemu_capabilities.h | 1 +
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index af52bbf..5e8f26a 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -205,7 +205,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
>                "usb-serial", /* 125 */
>                "usb-net",
>                "add-fd",
> -
> +              "nbd-server-start",
>      );
>  
>  struct _virQEMUCaps {
> @@ -1940,6 +1940,8 @@ virQEMUCapsProbeQMPCommands(virQEMUCapsPtr qemuCaps,
>              virQEMUCapsSet(qemuCaps, QEMU_CAPS_DISK_SNAPSHOT);
>          else if (STREQ(name, "add-fd"))
>              virQEMUCapsSet(qemuCaps, QEMU_CAPS_ADD_FD);
> +        else if (STREQ(name, "nbd-server-start"))
> +            virQEMUCapsSet(qemuCaps, QEMU_CAPS_NBD_SERVER);

Hmm, I just noticed the capability is called NBD_SERVER while it's
string representation is nbd-server-start. Would it be better to change
the string representation to "nbd-server" to make it consistent? It's a
minor issue, so ACK with or without the change.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]