[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/14] virsh: Use virDomainGetJobStats in domjobinfo if available



On Fri, Feb 22, 2013 at 08:18:56 +0100, Peter Krempa wrote:
> On 02/19/13 13:35, Jiri Denemark wrote:
> > ---
> >   tools/virsh-domain.c | 215 ++++++++++++++++++++++++++++++++++++++++-----------
> >   1 file changed, 169 insertions(+), 46 deletions(-)
> >
> > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> > index f8b0cec..ba05fa7 100644
> > --- a/tools/virsh-domain.c
> > +++ b/tools/virsh-domain.c
...
> > +    if ((rc = virTypedParamsGetULLong(params, nparams,
> > +                                      VIR_DOMAIN_JOB_MEMORY_NORMAL,
> > +                                      &value)) < 0) {
> > +        goto save_error;
> > +    } else if (rc) {
> > +        vshPrint(ctl, "%-17s %-12llu\n", _("Normal pages:"), value);
> >       }
> > +    if ((rc = virTypedParamsGetULLong(params, nparams,
> > +                                      VIR_DOMAIN_JOB_MEMORY_NORMAL_BYTES,
> > +                                      &value)) < 0) {
> > +        goto save_error;
> > +    } else if (rc) {
> > +        val = vshPrettyCapacity(value, &unit);
> > +        vshPrint(ctl, "%-17s %-.3lf %s\n", _("Normal data:"), val, unit);
> > +    }
> 
> Again, inconsistent empty line.

This is actually intentional. I wanted to group the code by fields
describing the same thing. So memory fields are grouped, time fields are
group, compression fields are grouped. And the groups are separated with
an empty line. But you're right I got it wrong in few places :-)

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]