[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't fail to shutdown domains with unresponsive agent



On 25.02.2013 19:33, Eric Blake wrote:
> On 02/25/2013 10:55 AM, Michal Privoznik wrote:
>> Currently, qemuDomainShutdownFlags() chooses the agent method of
>> shutdown whenever the agent is configured. However, this
>> assumption is not enough as the guest agent may be unresponsive
>> at the moment. So unless guest agent method has been explicitly
>> requested, we should fall back to the ACPI method.
>> ---
>>  src/qemu/qemu_driver.c | 34 ++++++++++++++++++++++++----------
>>  1 file changed, 24 insertions(+), 10 deletions(-)
> 
> When Daniel added two new shutdown methods for LXC, I had the question
> on whether shutdown methods should be mutually exclusive, or a bitmask
> of all permissible things to attempt (where passing 0 leaves the
> attempts up the hypervisor).  The consensus was that allowing the user
> to pass more than one method makes sense (although the hypervisor then
> gets to choose method priorities).  I'm not sure your logic matches the
> goal of allowing the user to request both agent and acpi at the same time.
> 

Aah. Okay; I thought they were considered as mutually exclusive. Hence
my code is not correct. Let me re-spin v2.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]