[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option



Il 26/02/2013 20:35, Anthony Liguori ha scritto:
>>> >> 
>>> >> See also discussion on multi-valued keys in command line option
>>> >> arguments and config files in v1 thread.  Hopefully we can reach a
>>> >> conclusion soon, and then we'll see whether this patch is what we want.
>> >
>> > Yeah, let's drop this patch by now. I am starting to be convinced that
>> > "cpus=A,cpus=B,cpus=C" is the best approach. It is not pretty, but at
>> > least it uses generic parser code instead of yet another ad-hoc
>> > parser.
> No, we cannot rely on this behavior.  We had to do it to support
> backwards compat with netdev but it should not be used anywhere else.

We chose a config format (git's) because it was a good match for
QemuOpts, and multiple-valued operations are well supported by that
config format; see git-config(1).  There is no reason to consider it a
backwards-compatibility hack.

Paolo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]