[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 1/8] libvirt: Update headers for doc



On 02/26/2013 07:18 AM, John Ferlan wrote:
> Update the function prototypes to include a message about the client needing
> to free() returned name fields.  Fix the all domains example flags values.
> 
> v3->v2 diff:
> Separted this out to it's own patch.

s/Separted/Separated/

then again, the information about v3->v2 diff belongs after a --- line,
so that 'git am' won't put it into git history (if someone else is
applying the patch).  If you are pushing the patch yourself, then be
sure to edit the commit message to drop version history at that time
(it's useful on list, but doesn't need to be part of the permanent logs).

> ---
>  src/libvirt.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)

ACK.  Let's get this into 1.0.3.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]