[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Hard requirement on gcrypt.h?



On 02/26/2013 05:01 PM, Eugene Marcotte wrote:
> On Tue, 2013-02-26 at 16:42 -0700, Eric Blake wrote:
>> I think we are guaranteed that gcrypt.h exists if gnutls is properly
>> installed, even if it is a transitive dependency.  Does this patch fix
>> it for you?
> 
> Yup, at least when building without gnutls it works fine. When building
> with gnutls (e.g. after yum install gnutls-devel) it also works fine.
> 
> Thanks!

With that review, I've gone ahead and pushed the patch.

> 
>> diff --git i/src/libvirt.c w/src/libvirt.c
>> index 8a28e4a..0a21dea 100644
>> --- i/src/libvirt.c
>> +++ w/src/libvirt.c
>> @@ -2,7 +2,7 @@
>>   * libvirt.c: Main interfaces for the libvirt library to handle
>> virtualization
>>   *           domains from a process running in domain 0
>>   *
>> - * Copyright (C) 2005-2006, 2008-2012 Red Hat, Inc.
>> + * Copyright (C) 2005-2006, 2008-2013 Red Hat, Inc.
>>   *
>>   * This library is free software; you can redistribute it and/or
>>   * modify it under the terms of the GNU Lesser General Public
>> @@ -31,7 +31,6 @@
>>  #include <unistd.h>
>>  #include <sys/wait.h>
>>  #include <time.h>
>> -#include <gcrypt.h>
>>
>>  #include <libxml/parser.h>
>>  #include <libxml/xpath.h>
>> @@ -56,6 +55,7 @@
>>  #include "intprops.h"
>>  #include "virconf.h"
>>  #if WITH_GNUTLS
>> +# include <gcrypt.h>
>>  # include "rpc/virnettlscontext.h"
>>  #endif
>>  #include "vircommand.h"
>>
>>
> 
> 
> 
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]