[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu: Don't fail to shutdown domains with unresponsive agent



On 27.02.2013 00:22, Eric Blake wrote:
> On 02/26/2013 04:02 AM, Michal Privoznik wrote:
>> Currently, qemuDomainShutdownFlags() chooses the agent method of
>> shutdown whenever the agent is configured. However, this
>> assumption is not enough as the guest agent may be unresponsive
>> at the moment. So unless guest agent method has been explicitly
>> requested, we should fall back to the ACPI method.
>> ---
>>
>> diff to v1:
>> - Rework some conditions as Eric suggested in v1
>>
>>  src/qemu/qemu_driver.c | 38 ++++++++++++++++++++++----------------
>>  1 file changed, 22 insertions(+), 16 deletions(-)
> 
> ACK.
> 

Do you think this one is safe to push now?
It is a bug fix and I think the code is well understood. However, the
issue it's fixing doesn't seem to be so usual to hit. Otherwise there
would be a bug report much sooner than 2012-12-22, right?

https://bugzilla.redhat.com/show_bug.cgi?id=889635

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]