[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option



On Wed, Feb 27, 2013 at 05:58:39PM +0100, Paolo Bonzini wrote:
> Il 27/02/2013 17:19, Eduardo Habkost ha scritto:
> >> > 
> >> > If it is meant as a prototype only, and the final command-line syntax
> >> > would be with repeated keys, that's okay.  I think that Eduardo/Markus/I
> >> > are focusing on the user interface, you're focusing in the implementation.
> >> > 
> >> > In the meanwhile, however, it seems to me that Eduardo can use
> >> > QemuOptsVisitor---which can also hide the details and provide type safety.
> > Whatever I use to implement it, I still need to know how the
> > command-line syntax will look like, because we need to tell libvirt
> > developers how they should write the QEMU command-line.
> 
> I don't think any syntax makes sense except cpus=A,cpus=B.  How we
> implement it is another story.

I agree completely, and I still don't know why Anthony doesn't like it.

-- 
Eduardo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]