[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Avoid spamming logs with cgroups warnings



On 02/27/2013 09:52 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The code for putting the emulator threads in a separate cgroup
> would spam the logs with warnings
> 
> 2013-02-27 16:08:26.731+0000: 29624: warning : virCgroupMoveTask:887 : no vm cgroup in controller 3
> 2013-02-27 16:08:26.731+0000: 29624: warning : virCgroupMoveTask:887 : no vm cgroup in controller 4
> 2013-02-27 16:08:26.732+0000: 29624: warning : virCgroupMoveTask:887 : no vm cgroup in controller 6

Yay - I'm tired of these as well.

> 
> This is because it has only created child cgroups for 3 of the
> controllers, but was trying to move the processes from all the
> controllers. The fix is to only try to move threads in the
> controllers we actually created. Also remove the warning and
> make it return a hard error to avoid such lazy callers in the
> future.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/qemu/qemu_cgroup.c | 5 +++++
>  src/util/vircgroup.c   | 3 +--
>  2 files changed, 6 insertions(+), 2 deletions(-)

ACK, and definitely 1.0.3 material.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]