[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix autodestroy of QEMU guests



On 02/27/2013 09:26 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virQEMUCloseCallbacksRunOne method was passing a uuid string
> to virDomainObjListFindByUUID, when it actually expected to get
> a raw uuid buffer. This was not caught by the compiler because
> the method was using a 'void *uuid' instead of first casting
> it to the expected type.
> 
> This regression was accidentally caused by refactoring in
> 
>   commit 568a6cda277f04ab9baaeb97490e548b7b608aa6
>   Author: Jiri Denemark <jdenemar redhat com>
>   Date:   Fri Feb 15 15:11:47 2013 +0100
> 
>     qemu: Avoid deadlock in autodestroy
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/qemu/qemu_conf.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

ACK - definite 1.0.3 material.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]