[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] qemu: fix graphics port allocation



On 02/27/2013 04:51 AM, Ján Tomko wrote:
> Only release ports that have been allocated before.
> 
> This fixes these issues:
> * trying to release ports when qemuProcessStart fails before port
>   allocation
> * trying to release the SPICE TLS port if spice_tls is 0
> * failing to release SPICE port with autoport=off (when only one
>   of them is -1)
> ---
> v1: https://www.redhat.com/archives/libvir-list/2013-February/msg01464.html
> Use a pair of booleans in domain private data instead of a new field
> in the domain definition.

Closer, but where is this information saved across libvirtd restarts?
Hint: qemu_domain.c:qemuDomainObjPrivateXML{Format,Parse}()

I think this counts as a bug fix, so it's worth trying to get a v3 in
time for the 1.0.3 release.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]