[libvirt] [PATCH 06/10] network: Bridge - Add support for a DHCP Relay Agent

Eric Blake eblake at redhat.com
Thu Feb 28 04:09:16 UTC 2013


On 02/27/2013 07:57 PM, TJ wrote:
> From: TJ <linux at iam.tj>
> 
> A DHCP relay daemon will be started that will forward all DHCP/BOOTP
> requests on the bridge network via the first declared forward
> interface. The relay is broadcast rather than routed so no IP address
> is needed on the bridge.
> 

> +static int
> +networkBuildDhcpRelayCommandLine(virNetworkObjPtr network, virCommandPtr *cmdout,
> +                                  char *pidfile)
> +{
> +    virCommandPtr cmd = NULL;
> +    int ret = -1;
> +
> +    cmd = virCommandNew(DHCPRELAY);

Your patches are out of order.  This patch tries to use DHCPRELAY, but
that isn't defined until patch 8/10 modifies configure.ac.  Squash those
two patches together.  Each patch needs to be buildable in isolation.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130227/f8139c30/attachment-0001.sig>


More information about the libvir-list mailing list