[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/10] conf: Network - add pointers to enabled virNetworkIpDef DHCP settings



On 02/27/2013 09:57 PM, TJ wrote:
> From: TJ <linux iam tj>
>
> Having previously introduced DHCP enabled and relay state within the
> virNetworkIpDef structure - which can be one of many on each network -
> these pointers allow us to track and easily access the DHCP state for
> IPv4 and IPv6 when setting up the network without having to iterate
> every virNetworkIpDef to find the DHCP state.


I'm not sure I like this. Having these convenience pointers is, er,
convenient, but it also means that you must maintain them, for example
during virNetworkUpdate* (a series of calls to this could potentially
remove all dhcp info from one IP address, and add it into another IP
address). That means more potential for getting it out of synce due to
missing a change in some obscure place.


>
> Signed-off-by: TJ <linux iam tj>
> ---
>  src/conf/network_conf.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h
> index 8400eab..1889c45 100644
> --- a/src/conf/network_conf.h
> +++ b/src/conf/network_conf.h
> @@ -231,6 +231,8 @@ struct _virNetworkDef {
>      virPortGroupDefPtr portGroups;
>      virNetDevBandwidthPtr bandwidth;
>      virNetDevVlan vlan;
> +    virNetworkIpDefPtr ipv4_dhcp;
> +    virNetworkIpDefPtr ipv6_dhcp;
>  };
>  
>  typedef struct _virNetworkObj virNetworkObj;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]