[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/10] configure: Add DHCPRELAY to the set of external program definitions



On 02/27/2013 09:57 PM, TJ wrote:
> From: TJ <linux iam tj>
>
> This variable should name the path to the system's DHCP relay daemon.
>
> At this time the expected daemon is "dhcp-helper", a DHCP relay agent
> from Simon Kelly, author of dnsmasq.
>
> The supporting code, however, has been designed to work with any
> suitable DHCP relay agent. Later patches could allow configuration
> of the agent's command-line arguments.
>
> Currently the chosen agent must support:
>
> -b <bridge_interface> (the virtual network to listen on)
> -i <physical_interface> (the interface to broadcast on)
> -r </path/to/pid.file> (the PID file of the daemon)
>
> Signed-off-by: TJ <linux iam tj>
> ---
>  configure.ac | 4 ++++
>  1 file changed, 4 insertions(+)

This should have come much earlier in the series, probably as just
another part of a single larger patch.

>
> diff --git a/configure.ac b/configure.ac
> index e3a749a..b62170e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -295,6 +295,8 @@ dnl External programs that we can use if they are available.
>  dnl We will hard-code paths to these programs unless we cannot
>  dnl detect them, in which case we'll search for the program
>  dnl along the $PATH at runtime and fail if it's not there.
> +AC_PATH_PROG([DHCPRELAY], [dhcp-helper], [dhcp-helper],
> +	[/sbin:/usr/sbin:/usr/local/sbin:$PATH])
>  AC_PATH_PROG([DNSMASQ], [dnsmasq], [dnsmasq],
>  	[/sbin:/usr/sbin:/usr/local/sbin:$PATH])
>  AC_PATH_PROG([RADVD], [radvd], [radvd],
> @@ -314,6 +316,8 @@ AC_PATH_PROG([OVSVSCTL], [ovs-vsctl], [ovs-vsctl],
>  AC_PATH_PROG([SCRUB], [scrub], [scrub],
>  	[/sbin:/usr/sbin:/usr/local/sbin:$PATH])
>  
> +AC_DEFINE_UNQUOTED([DHCPRELAY], ["$DHCPRELAY"],
> +	[Location or name of the dhcp relay-agent program])
>  AC_DEFINE_UNQUOTED([DNSMASQ],["$DNSMASQ"],
>          [Location or name of the dnsmasq program])
>  AC_DEFINE_UNQUOTED([RADVD],["$RADVD"],


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]