[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] python: optimize SAX xml parsing event handler



On 02/28/2013 03:03 AM, Guannan Ren wrote:
> close(), getmethodname(), cdata() are not standard methods from
> parent class ContentHandler and not being used anywhere in codes,
> so remove them.
> 
> In docParser, actually, we are overloading three parent methods
> startElement(), endElement() and characters(), so I rename back
> three of these method names for example from start()
> to startElement() which makes it simpler to read.
> 
> make other improvements in codes.

Someone else will have to review this.  Sorry.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]