[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Adapt to new log format



On 02.01.2013 11:25, Daniel P. Berrange wrote:
> On Sat, Dec 29, 2012 at 10:09:41AM +0100, Michal Privoznik wrote:
>> Since 586502189edf9fd0f89a83de96717a2ea826fdb0 qemu commit, the log
>> lines reporting chardev's path has changed from:
>>
>> $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty
>> char device redirected to /dev/pts/5
>> char device redirected to /dev/pts/6
>> char device redirected to /dev/pts/7
>>
>> to:
>>
>> $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty
>> char device compat_monitor0 redirected to /dev/pts/5
>> char device serial0 redirected to /dev/pts/6
>> char device serial1 redirected to /dev/pts/7
>>
>> However, with current code we are not prepared for such change, which
>> results in us being unable to start any domain.
> 
> Huh, we should not be relying on this data at all with current
> QEMU. We switched to using 'info chardev' / 'query-chardev'
> years ago.
> 
> NACK to this patch. You need to find out what it is not using the
> monitor for this.
> 
> Daniel
> 

Okay, I've reverted the patch and will search for the root cause.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]