[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't parse log output when starting up a domain



On 02.01.2013 18:45, Eric Blake wrote:
> On 01/02/2013 08:23 AM, Michal Privoznik wrote:
>> Despite our great effort we still parsed qemu log output.
>> We wouldn't notice unless qemu changed the format of the
>> logs slightly.
> 
> Maybe mention that the upcoming qemu 1.4 does just that.
> 
>> Anyway, now we should gather all interesting
>> knobs like pty paths from monitor. Moreover, since for
>> historical reasons the first console can be just an alias to
>> the first serial port, we need to check this and copy the
>> pty path if that's the case to the first console.
>> ---
>>  src/qemu/qemu_capabilities.c |  7 +++++++
>>  src/qemu/qemu_capabilities.h |  1 +
>>  src/qemu/qemu_process.c      | 20 ++++++++++++++++++--
>>  3 files changed, 26 insertions(+), 2 deletions(-)
> 
> ACK, with a grammar nit.
> 
>> @@ -1544,8 +1545,23 @@ qemuProcessFindCharDevicePTYsMonitor(virDomainObjPtr vm,
>>      if (qemuProcessLookupPTYs(vm->def->channels, vm->def->nchannels,
>>                                paths, chardevfmt) < 0)
>>          return -1;
>> +    /* For historical reasons, console[0] can be just an alias
>> +     * for serial[0]; That's why we need to update it as well */
> 
> Either you are starting a new sentence and need a full stop ("serial[0].
> That's"), or you don't need a capital after semicolon ("serial[0];
> that's").  Also, s/well/well./ wouldn't hurt.
> 

Fixed and pushed. Thanks.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]