[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/10] Ignore error returns for virBufferTrim().



On Thu, Jan 03, 2013 at 02:16:21PM -0500, John Ferlan wrote:
> ---
>  tools/virsh.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virsh.c b/tools/virsh.c
> index 283194a..9f834e4 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -544,7 +544,7 @@ vshTreePrintInternal(vshControl *ctl,
>                                   false, indent) < 0)
>              goto cleanup;
>      }
> -    virBufferTrim(indent, "  ", -1);
> +    ignore_value(virBufferTrim(indent, "  ", -1));
>  
>      /* If there was no child device, and we're the last in
>       * a list of devices, then print another blank line */
> @@ -552,7 +552,7 @@ vshTreePrintInternal(vshControl *ctl,
>          vshPrint(ctl, "%s\n", virBufferCurrentContent(indent));
>  
>      if (!root)
> -        virBufferTrim(indent, NULL, 2);
> +        ignore_value(virBufferTrim(indent, NULL, 2));
>      ret = 0;
>  cleanup:
>      return ret;

I must say I don't see the point in the return value
for virBufferTrim. I think I'd recommend turning it
into a 'void' function

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]