[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] The -vga CLI arg accepts qxl in qemu 1.2+ always



On 01/03/2013 04:42 PM, Doug Goldstein wrote:
> The -vga command always accepts qxl in 1.2 and newer.

Are you sure?  I thought qemu ./configure allows a choice of which
graphics engines to support, and that you can compile qxl out (distros
don't do that, but a self-built qemu might support -vga but not QXL).  I
think that rather than blindly setting this cap, we need to find the
right QMP command to check which graphics engines are supported.

> ---
>  src/qemu/qemu_capabilities.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index f49a31c..c3ab488 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -2282,6 +2282,7 @@ qemuCapsInitQMPBasic(qemuCapsPtr caps)
>      qemuCapsSet(caps, QEMU_CAPS_NO_USER_CONFIG);
>      qemuCapsSet(caps, QEMU_CAPS_NETDEV_BRIDGE);
>      qemuCapsSet(caps, QEMU_CAPS_SECCOMP_SANDBOX);
> +    qemuCapsSet(caps, QEMU_CAPS_VGA_QXL);
>  }
>  
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]