[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Detect VGA_QXL capability correctly



On 01/04/2013 07:10 AM, Michal Privoznik wrote:
>>
>>     The problem here is about collecting cap flags via QMP, we need to
>> set QEMU_CAPS_VGA_QXL
>>     unconditionally but still in discussion.

That discussion was conclusive - we do not want the flag unconditionally.

>>
>>   Patch from Doug Goldstein in [libvirt] [PATCH] The -vga CLI arg
>> accepts qxl in qemu 1.2+ always
>>
>> The -vga command always accepts qxl in 1.2 and newer.

Not true...

> I don't think it should be set unconditionally neither. I know I wrote
> it under commit message, but now re-thinking it again - what if somebody
> builds his own qemu without QXL?

...precisely because of this possibility.  Michal's patch is correct -
if QXL is available, then -vga qxl is available; but it is possible to
self-build qemu without QXL.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]