[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/10] Ignore the return status check for vmwareUpdateVMStatus in convenience routine vmwareDomainObjListUpdateDomain



On 01/03/2013 12:16 PM, John Ferlan wrote:
> ---
>  src/vmware/vmware_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c
> index 3763f40..9c81df8 100644
> --- a/src/vmware/vmware_driver.c
> +++ b/src/vmware/vmware_driver.c
> @@ -949,7 +949,7 @@ static void vmwareDomainObjListUpdateDomain(void *payload, const void *name ATTR
>      struct vmware_driver *driver = data;
>      virDomainObjPtr vm = payload;
>      virDomainObjLock(vm);
> -    vmwareUpdateVMStatus(driver, vm);
> +    ignore_value(vmwareUpdateVMStatus(driver, vm));

ACK, I'll reformat the commit message and push this one soon.  As for
3/10, it looks like there is still a discussion going on as to whether
to warn or silently ignore failure to set the hint, so I deferred
pushing that one for now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]