[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/10] Check return status for setting TCP_NODELAY option and generate a VIR_DEBUG message on failure. Allow connection to continue.



On 01/03/2013 02:36 PM, Daniel P. Berrange wrote:
> On Thu, Jan 03, 2013 at 02:16:17PM -0500, John Ferlan wrote:
>> ---
>>  src/xen/xend_internal.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
>> index 84a25e8..1f779b0 100644
>> --- a/src/xen/xend_internal.c
>> +++ b/src/xen/xend_internal.c
>> @@ -91,8 +91,10 @@ do_connect(virConnectPtr xend)
>>      /*
>>       * try to desactivate slow-start
>>       */
>> -    setsockopt(s, IPPROTO_TCP, TCP_NODELAY, (void *)&no_slow_start,
>> -               sizeof(no_slow_start));
>> +    if (setsockopt(s, IPPROTO_TCP, TCP_NODELAY, (void *)&no_slow_start,
>> +                   sizeof(no_slow_start)) < 0) {
>> +        VIR_DEBUG("Unable to disable nagle algorithm");
>> +    }
> 
> Hmm, I'd just make this  ignore_value() i think - it is something we
> expect to fail with UNIX sockets
> 
> Daniel
> 

Comparing this to src/rpc/virnetsocket.c which also uses TCP_NODELAY and
errors out I figured that in this case having a debug message may be
useful if someone was debugging a problem, but I have no other argument
for not using ignore_value().  Going back also allows me to fix the comment.

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]