[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix substitution of sbindir in virtlockd.service



Eric Blake wrote:
> On 01/04/2013 11:43 AM, Eric Blake wrote:
>   
>> On 01/04/2013 11:14 AM, Jim Fehlig wrote:
>>     
>>> The makefile rule substitutes variables delimited by '::', but the
>>> virtlockd service files uses '@'.  Change the service file to
>>> match the makefile rule.
>>>       
>> I'd much rather see us unify the different makefile .in conversions to
>> use the same syntax - I see:
>>
>> libvirtd.8.in: s!SYSCONFDIR!$(sysconfdir)!g
>>
>> libvirtd.policy.in, libvirtd.logrotate.in, libvirtd.qemu.logrotate.in,
>> ...: s![ ]authaction[@]!$(policyauth)!g
>>
>> libvirtd.init.in, libvirtd.service.in:
>> s!\ localstatedir\@!$(localstatedir)!g
>> (hmm, \@ is not a portable regex, and may die on some platforms)
>>     
>
> Another non-portability - ! can be used in filenames without quoting,
> and thus might appear in (an admittedly unusual) $(localstatedir), which
> then messes up sed.  So autoconf advices using '|', rather than ',' or
> '!', when setting up a substitution of a filename.
>
> I'm preparing a patch to fix all of these concerns.
>   

Ah, ok.  I finished your first suggestion but will drop it since you're
working on a patch to fix all the issues.

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]