[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Install virtlockd.{socket, service} non executable



On 01/03/2013 03:05 PM, Guido Günther wrote:
> since they're not scripts but systemd service files.
> ---
>  src/Makefile.am |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index f7a9b91..0cfc1ed 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1687,9 +1687,9 @@ DISTCLEANFILES += virtlockd.service virtlockd.socket
>  
>  install-systemd: virtlockd.service virtlockd.socket install-sysconfig
>  	$(MKDIR_P) $(DESTDIR)$(SYSTEMD_UNIT_DIR)
> -	$(INSTALL_SCRIPT) virtlockd.service \
> +	$(INSTALL_DATA) virtlockd.service \
>  	  $(DESTDIR)$(SYSTEMD_UNIT_DIR)/
> -	$(INSTALL_SCRIPT) virtlockd.socket \
> +	$(INSTALL_DATA) virtlockd.socket \
>  	  $(DESTDIR)$(SYSTEMD_UNIT_DIR)/

Hmm.  This needs a followup - we don't need chmod a+x when creating
these files.  For that matter, since virtlockd.socket has no
substitutions being made on it, we could install it directly instead of
going through a .in file.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]