[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] Public API to allow defining new domain using OVA file



On Sat, Jan 05, 2013 at 11:33:51PM -0800, Ata E Husain Bohra wrote:
> Appends a new API to libvirt public driver that supports
> defining a new domain using OVA format.
> 
> API expects following inputs:
> 1. connection pointer.
> 2. path to OVA package (single file format).
> 3. Storage pool name where new domain needs to be created.
> 
> API returns pointers to newly created domain that is not powered ON.
> 
> Libvirt driver sanitizes the inputs and calls hypervisor specific
> driver callbacks to abstract OVA install implementation.
> ---
>  include/libvirt/libvirt.h.in |    3 +++
>  src/driver.h                 |    5 ++++
>  src/libvirt.c                |   58 ++++++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms      |    5 ++++
>  4 files changed, 71 insertions(+)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 09c89c5..ea342bc 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -1919,6 +1919,9 @@ int                     virDomainMemoryPeek (virDomainPtr dom,
>   */
>  virDomainPtr            virDomainDefineXML      (virConnectPtr conn,
>                                                   const char *xml);
> +virDomainPtr            virDomainDefineOVA      (virConnectPtr conn,
> +                                                 const char *ovapath,
> +                                                 const char *poolname);


NACK,  as I said with previous postings, this does not belong in
libvirt APIs, it should be built as a layer above. Further this
API design fundamentally flawed as it is assuming the hypervisor
driver can access files that are on the libvirt application
machine which is not the case in general.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]