[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] BZ 657918 Default iptables setup in libvirt breaks mDNS



On 12/12/2012 01:19 PM, Laine Stump wrote:
> On 12/11/2012 07:05 PM, Brian J. Murrell wrote:
>> On 12-12-11 06:24 PM, Eric Blake wrote:
>>> Thanks!
>> NP.  Had it just lying around here anyway.  :-)
>>  
>>> Comment should now mention 4 rules.
>> Doh!  Missed that in the patch port.  Updated in my local copy (which I
>> will of course resend once all of the initial review is done).
> 
> The one thing I would ask beyond Eric's suggestions is that you use git
> send-email to produce the patches - the patch you've sent doesn't apply
> with git am, which would make it a pain to properly attribute to you.
> 
> If you're unfamiliar with using git, here's what you would do:
> 
> 1) git clone git://libvirt.org/libvirt.git
> 
> 2) cd libvirt
> 
> 3) edit the files.
> 
> 4) make check && make syntax-check (and fix any problems they find)
> 
> 4) git add $list-of-files
> 
> 5) git commit
> 
>    (give a nice descriptive log message with subject of
>     "network: support mDNS on NAT networks")
> 
> 6) git send-email -1
> 
>    (tell it to send to libvir-list redhat com)
> 
> I can then directly apply the patch with git am.

I noticed this hadn't been applied yet, and was wondering if you were
still planning on resubmitting this patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]