[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add RESUME event listener to qemu monitor.



On Mon, Jan 07, 2013 at 10:44:41PM +0000, Daniel P. Berrange wrote:
> On Mon, Jan 07, 2013 at 04:25:01PM -0500, Andres Lagar-Cavilla wrote:
> > Perform all the appropriate plumbing.
> > 
> > When qemu/KVM VMs are paused manually through a monitor not-owned by libvirt,
> > libvirt will think of them as "paused" event after they are resumed and
> > effectively running. With this patch the discrepancy goes away.
> > 
> > This is meant to address bug 892791.
> > 
> > Signed-off-by: Andres Lagar-Cavilla <andres lagarcavilla org>
> 
> Although we don't support people issuing monitor commands behind
> libvirt's back, I see no harm in handling the resume event here,
> as long as we don't end up emitting multiple resume events for
> a single operation (eg if libvirt triggers the resume it already
> emits an event indepedently)

+1

Dave

> Daniel
> -- 
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]