[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3]add usb-net support for qemu



On Tue, Jan 08, 2013 at 03:03:23PM -0500, Laine Stump wrote:
> On 01/03/2013 02:13 AM, Guannan Ren wrote:
> > The set of patches fixed some typo in network docs and codes and
> > is trying to support usb-net qemu virtual device.
> >
> > The following is an example for use.
> >
> > Libvirt XML sample:
> >   <devices>
> >     <interface type='user'>
> >       <mac address='52:54:00:32:6a:91'/>
> >       <model type='usb-net'/>
> 
> Do we really want the model type to be "usb-net"? the "-net" part is
> already implicit in the type of device, and there is no requirement that
> it needs to exactly match the qemu commandline parameter (although I
> suppose that's normally the case). As a matter of fact, <type
> model='virtio'/> ends up being equivalent to "-device virtio-net-pci".

Indeed, we should really base the name on the actual hardware
since there can be many many different USB NICs implemented.

Finding a model name in the usb.ids file is a good place to
start

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]