[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] qemu: add usb-net support



On Tue, Jan 08, 2013 at 04:02:02PM -0500, Laine Stump wrote:
> On 01/03/2013 02:13 AM, Guannan Ren wrote:
> > Libvirt XML sample:
> >   <devices>
> >     <interface type='user'>
> >       <mac address='52:54:00:32:6a:91'/>
> >       <model type='usb-net'/>
> >       <alias name='net1'/>
> >       <address type='usb' bus='0' port='1'/>
> >     </interface>
> >   </devices>
> >
> > qemu commandline:
> >
> > qemu ${other_vm_args}
> >     -netdev user,id=hostnet1 \
> >     -device usb-net,netdev=hostnet1,id=net1,\
> >       mac=52:54:00:32:6a:91,bus=usb.0,port=1
> > ---
> >  docs/formatdomain.html.in |  4 +++-
> >  src/conf/domain_conf.c    | 18 +++++++++++++-----
> >  src/qemu/qemu_command.c   |  8 +++++++-
> >  3 files changed, 23 insertions(+), 7 deletions(-)
> >
> > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> > index 45d7593..fbd77f2 100644
> > --- a/docs/formatdomain.html.in
> > +++ b/docs/formatdomain.html.in
> > @@ -2952,7 +2952,9 @@ qemu-kvm -net nic,model=? /dev/null
> >  
> >      <p>
> >        Typical values for QEMU and KVM include:
> > -      ne2k_isa i82551 i82557b i82559er ne2k_pci pcnet rtl8139 e1000 virtio
> > +      ne2k_isa i82551 i82557b i82559er ne2k_pci pcnet rtl8139 e1000 virtio.
> > +      Besides above, there is a model of usb-net which is a QEMU USB Network interface
> 
>   ne2k_isa i82551 i82557b i82559er ne2k_pci pcnet rtl8139 e1000 virtio XXXX.
>   (All of these models are PCI devices, except "XXXX" which emulates a
>   $manufacturers-name XXXX usb ethernet device.
> 
> (A bit off topice, but it's actually kind of starting to bother me that
> we just blindly pass-through all the other netdev models rather than
> validating them...)

Yes, it is overdue to turn that into an enum as we do for other
hardware models 

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]