[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Make TLS support conditional



On 01/08/2013 01:47 PM, Daniel P. Berrange wrote:
> On Mon, Jan 07, 2013 at 05:37:30PM -0700, Eric Blake wrote:
>>
>> Touches quite a bit, but hopefully for the better.  What platform are
>> you targeting where you were unwilling to require gnutls as a prereq?
> 
> No specific platform as such, just that if you build with
> --without-remote and --without-libvirtd we should not be
> mandating use of gnutls. Various people have asked for this
> feature over the years, so I think it is worth it.
> 
>>
>> Overall, your patch looks sane, and you have a 'weak ACK' - that is, I'm
>> willing to look the other way and let this patch go in, if you don't
>> think it is worth even more refactoring to avoid quite so much leaky
>> #ifdef throughout the code base.
> 
> Basically I'm following the approach used for SASL. It would be nice to
> try and adapt virnet{tls,sasl}context.c so that all the functions still
> exist, but have no-op impls, but that's much more work - I've tried it
> before with SASL but never got a satisfactory result

As it is, with your patch, I just got this failure on RHEL 5:

/usr/bin/perl ./check-symfile.pl l ibvirt.yms \
    .libs/libvirt.so
Expected symbol virNetServerClientGetTLSKeySize is not in ELF library
...

I still need to do more investigation, but it makes me wonder if we got
the conditional symfile manipulation correct?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]