[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] add qemu pci-express device support



在 2013-01-09三的 10:32 +0000,Daniel P. Berrange写道:
> On Wed, Jan 09, 2013 at 10:35:32AM +0800, liguang wrote:
> > Signed-off-by: liguang <lig fnst cn fujitsu com>
> > ---
> >  src/conf/device_conf.c       |    8 +++++++-
> >  src/conf/device_conf.h       |    1 +
> >  src/qemu/qemu_capabilities.c |   11 +++++++++++
> >  src/qemu/qemu_capabilities.h |    1 +
> >  src/qemu/qemu_command.c      |    4 +++-
> >  5 files changed, 23 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c
> > index 7b97f45..3fca853 100644
> > --- a/src/conf/device_conf.c
> > +++ b/src/conf/device_conf.c
> > @@ -51,7 +51,7 @@ int
> >  virDevicePCIAddressParseXML(xmlNodePtr node,
> >                              virDevicePCIAddressPtr addr)
> >  {
> > -    char *domain, *slot, *bus, *function, *multi;
> > +    char *domain, *slot, *bus, *function, *multi, *expr;
> >      int ret = -1;
> >  
> >      memset(addr, 0, sizeof(*addr));
> > @@ -61,6 +61,7 @@ virDevicePCIAddressParseXML(xmlNodePtr node,
> >      slot     = virXMLPropString(node, "slot");
> >      function = virXMLPropString(node, "function");
> >      multi    = virXMLPropString(node, "multifunction");
> > +    expr     = virXMLPropString(node, "express");
> 
> NACK, this is a gross hack.
> 
> The q35 machine type provides multiple PCI buses, and it is
> already possible to express connection to the alternative
> buses using the 'bus' parameter. We don't need a new 'express'
> parameter. We need to make sure that the XML includes a
> <controller> element for each PCI bus provided by a machine
> type
> 
> Daniel

OK, will drop this unnecessary patch.

-- 
regards!
li guang



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]