[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: move file deleting action from %files list to %install



On 01/10/2013 06:47 AM, Laine Stump wrote:

>>>
>>> It is triggerd by the %files list of libvirt daemon:
>>>
>>>     %if 0%{?fedora} >= 14 || 0%{?rhel} >= 6
>>>     %config(noreplace) %{_prefix}/lib/sysctl.d/libvirtd.conf
>>>     %else
>>>     rm -f $RPM_BUILD_ROOT%{_prefix}/lib/sysctl.d/libvirtd.conf
>>>     %endif
>>>

>> %if 0%{?fedoa} < 14 && 0%{?rhel} < 6
>>
>> ACK with that change, and will push shortly.
> 
> Does anybody other than RHEL or Fedora use the specfile? If they ever
> did, yours would fail too :-)

No - if anyone other than RHEL or Fedora uses the specfile, then
%{_prefix}/lib/sysctl.d/libvirtd.conf is never installed, so it must be
removed to avoid rpm complaining about leftover files.  It some other
distro wants libvirtd.conf installed, they have to touch both code
places, keeping the conditions in sync (and if that is the case, there's
probably a lot of other conditions they'd want to tweak).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]